-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pydantic version and update corresponding fsapi code #1330
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
==========================================
- Coverage 94.25% 94.25% -0.01%
==========================================
Files 370 370
Lines 37952 37951 -1
==========================================
- Hits 35770 35769 -1
Misses 2182 2182 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @MichaelPesce!
Fixes/Resolves:
#1273
Summary/Motivation:
Other packages are reliant on pydantic having version >= 2.0.0
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: