Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sweep analysis for electroNP flowsheet #1077

Merged
merged 61 commits into from
Jul 19, 2023

Merge branch 'main' into electroNP_flowsheet3

a8efd9a
Select commit
Loading
Failed to load commit list.
Merged

Add sweep analysis for electroNP flowsheet #1077

Merge branch 'main' into electroNP_flowsheet3
a8efd9a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 19, 2023 in 1s

95.49% (+0.10%) compared to d9408fd

View this Pull Request on Codecov

95.49% (+0.10%) compared to d9408fd

Details

Codecov Report

Merging #1077 (a8efd9a) into main (d9408fd) will increase coverage by 0.10%.
The diff coverage is 69.38%.

@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   95.38%   95.49%   +0.10%     
==========================================
  Files         315      319       +4     
  Lines       31051    31138      +87     
==========================================
+ Hits        29619    29735     +116     
+ Misses       1432     1403      -29     
Impacted Files Coverage Δ
watertap/costing/watertap_costing_package.py 100.00% <ø> (ø)
...s/flowsheets/case_studies/electroNP/multi_sweep.py 43.39% <43.39%> (ø)
watertap/costing/units/electroNP.py 100.00% <100.00%> (ø)
...eets/case_studies/electroNP/electroNP_flowsheet.py 95.94% <100.00%> (+7.71%) ⬆️
watertap/unit_models/electroNP_ZO.py 97.20% <100.00%> (+0.08%) ⬆️

... and 8 files with indirect coverage changes