Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sweep analysis for electroNP flowsheet #1077
Add sweep analysis for electroNP flowsheet #1077
Changes from 49 commits
7d35890
4766c52
ef81bae
168bbaf
a09b4e9
44a22e8
1c1a135
401f997
258f6fe
2c994c3
5b6baed
0afa551
479fb6d
b393ed0
708ad0a
5a69761
112415a
93737c0
3162e34
637b32d
ea4e066
84a2900
17bc5e3
f816483
5070b6b
94c0d87
fea68e3
2f24258
4e00192
11501c1
4454b7f
c19fba5
f0fa980
00abb0c
0754d21
9dcece1
c0f1afe
3a59826
aa39be3
a5325c9
c4bc3ef
991343b
e317d5e
bb8ca41
ffb686e
c4a60cc
a35aa0f
22d789d
1368258
e858266
b0fdd3a
f7aa5e8
0c1cad3
ff5a4c7
83006fe
5afdc55
35c26de
f6c19cc
35ecf79
311175e
a8efd9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked why we can skip this constraints and the model still works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason I could imagine is the removal fraction is setting to a really small value 1e-7 and these components should just pass through, but I still want to keep these removal equations just in case if we want to update these removal fractions later.
Check warning on line 210 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L209-L210
Check warning on line 213 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L213
Check warning on line 218 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L216-L218
Check warning on line 227 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L226-L227
Check warning on line 232 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L232
Check warning on line 234 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L234
Check warning on line 243 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L243
Check warning on line 245 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L245
Check warning on line 263 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L263
Check warning on line 271 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L271
Check warning on line 273 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L273
Check warning on line 277 in watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py
Codecov / codecov/patch
watertap/examples/flowsheets/case_studies/electroNP/electroNP_flowsheet.py#L277