-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sweep analysis for electroNP flowsheet #1077
Merged
adam-a-a
merged 61 commits into
watertap-org:main
from
luohezhiming:electroNP_flowsheet3
Jul 19, 2023
Merged
Changes from 60 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
7d35890
add
luohezhiming 4766c52
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming ef81bae
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 168bbaf
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming a09b4e9
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 44a22e8
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 1c1a135
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 401f997
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 258f6fe
delete redundant files
luohezhiming 2c994c3
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 5b6baed
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 0afa551
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 479fb6d
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming b393ed0
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 708ad0a
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 5a69761
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 112415a
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 93737c0
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 3162e34
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 637b32d
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming ea4e066
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 84a2900
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 17bc5e3
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming f816483
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 5070b6b
add sensitivity analysis
luohezhiming 94c0d87
add sweep analysis
luohezhiming fea68e3
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 2f24258
Merge branch 'main' into electroNP_flowsheet_analysis
luohezhiming 4e00192
add sweep analysis
luohezhiming 11501c1
add more analysis
luohezhiming 4454b7f
add analysis
luohezhiming c19fba5
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming f0fa980
revise file
luohezhiming 00abb0c
add more analysis
luohezhiming 0754d21
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 9dcece1
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming c0f1afe
Merge branch 'main' into electroNP_flowsheet_analysis
luohezhiming 3a59826
revise flowsheet
luohezhiming aa39be3
revise analysis
luohezhiming a5325c9
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming c4bc3ef
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 991343b
Merge branch 'main' into electroNP_flowsheet3
luohezhiming e317d5e
add sweep analysis
luohezhiming bb8ca41
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming ffb686e
Merge branch 'main' into electroNP_flowsheet3
luohezhiming c4a60cc
delete scaling factors
luohezhiming a35aa0f
revise test file
luohezhiming 22d789d
revise opex frac
luohezhiming 1368258
plinting code
luohezhiming e858266
Update watertap/costing/units/electroNP.py
luohezhiming b0fdd3a
Update watertap/costing/units/electroNP.py
luohezhiming f7aa5e8
Update watertap/costing/units/electroNP.py
luohezhiming 0c1cad3
Update watertap/examples/flowsheets/case_studies/electroNP/multi_swee…
luohezhiming ff5a4c7
clean up the code
luohezhiming 83006fe
revise value
luohezhiming 5afdc55
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 35c26de
Merge branch 'main' into electroNP_flowsheet3
luohezhiming f6c19cc
add test for display_costing
luohezhiming 35ecf79
Merge branch 'main' of https://github.com/watertap-org/watertap
luohezhiming 311175e
Merge branch 'main' into electroNP_flowsheet3
luohezhiming a8efd9a
Merge branch 'main' into electroNP_flowsheet3
adam-a-a File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked why we can skip this constraints and the model still works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason I could imagine is the removal fraction is setting to a really small value 1e-7 and these components should just pass through, but I still want to keep these removal equations just in case if we want to update these removal fractions later.