Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse PR930 with PR1038 #1108

Closed
wants to merge 145 commits into from
Closed

Conversation

adam-a-a
Copy link
Contributor

Fixes/Resolves:

Summary/Motivation:

Safety net to make sure PR#930 won't severely upset PR#1038.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adam-a-a adam-a-a requested a review from bknueven August 17, 2023 21:08
@adam-a-a adam-a-a self-assigned this Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1108 (b8b2290) into main (079afdc) will decrease coverage by 0.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   95.55%   95.55%   -0.01%     
==========================================
  Files         327      327              
  Lines       31909    31914       +5     
==========================================
+ Hits        30491    30495       +4     
- Misses       1418     1419       +1     
Files Changed Coverage Δ
watertap/core/plugins/solvers.py 99.18% <ø> (-0.03%) ⬇️
...urce_recovery_facility/full_WRRF_with_ASM1_ADM1.py 99.50% <ø> (ø)
watertap/examples/flowsheets/nf_dspmde/nf.py 93.17% <ø> (ø)
watertap/examples/chemistry/chem_scaling_utils.py 96.72% <91.66%> (-1.36%) ⬇️
...ry/posttreatment_ideal_naocl_chlorination_block.py 94.44% <100.00%> (ø)
...ap/examples/flowsheets/nf_dspmde/nf_with_bypass.py 96.29% <100.00%> (ø)

@adam-a-a
Copy link
Contributor Author

Reason for Closing: This PR was just used as a safeguard to check compatibility between two high-priority PRs.

@adam-a-a adam-a-a closed this Aug 20, 2023
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants