Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NaCl recovery value to crystallizer model #1120

Merged
merged 12 commits into from
Sep 8, 2023
Merged

Add NaCl recovery value to crystallizer model #1120

merged 12 commits into from
Sep 8, 2023

Commits on Sep 6, 2023

  1. add NaCl value

    Zhuoran Zhang authored and Zhuoran Zhang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    0b59610 View commit details
    Browse the repository at this point in the history

  2. change opex domain

    Zhuoran Zhang authored and Zhuoran Zhang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    bd6e3c5 View commit details
    Browse the repository at this point in the history

  3. update solutions

    Zhuoran Zhang authored and Zhuoran Zhang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    8c0cfb0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into crystallizer_mod

    @Zhuoran29
    Zhuoran29 authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    1613def View commit details
    Browse the repository at this point in the history

  5. update solutions

    Zhuoran Zhang authored and Zhuoran Zhang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    7c88402 View commit details
    Browse the repository at this point in the history

  6. update solution

    Zhuoran Zhang authored and Zhuoran Zhang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    5afca59 View commit details
    Browse the repository at this point in the history

  7. update more solutions

    Zhuoran Zhang authored and Zhuoran Zhang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d4d177b View commit details
    Browse the repository at this point in the history

  8. merge main

    Zhuoran Zhang authored and Zhuoran Zhang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    f201ced View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. macOS fail fix trial

    Zhuoran Zhang authored and Zhuoran Zhang committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    3907d61 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into crystallizer_mod

    @bknueven
    bknueven authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    74eb982 View commit details
    Browse the repository at this point in the history

  3. Update watertap/unit_models/tests/test_crystallizer.py 

    Change to absolute tolerance for zeros.

Co-authored-by: Adam Atia <aatia@keylogic.com>
    @Zhuoran29 @adam-a-a
    Zhuoran29 and adam-a-a authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    0b8e1b8 View commit details
    Browse the repository at this point in the history

  4. Update watertap/unit_models/tests/test_crystallizer.py 

    Try GHA again; assert closer to 0
    @bknueven
    bknueven authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a17266d View commit details
    Browse the repository at this point in the history