-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate bounds relaxation for WaterTAP Ipopt #1140
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d465217.
bknueven
changed the title
[WIP] try reducing bounds overrelaxation
Eliminate bounds relaxation for WaterTAP Ipopt
Sep 21, 2023
This reverts commit 5821a2c.
bknueven
force-pushed
the
bound_relax_common
branch
from
September 21, 2023 21:58
b6cf738
to
0c96da7
Compare
bknueven
force-pushed
the
bound_relax_common
branch
from
September 22, 2023 21:16
08fdf4a
to
498111e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves: N/A
@avdudchenko reports in consistencies in the way
domain=pyo.NonNegativeReals
vsbounds=(0, None)
. I tracked this down to an issue in the way "bounds relaxation" is handled in the WaterTAP wrapper for Ipopt.This PR would resolve this issue by turning off bounds relaxation altogether for the WaterTAP wrapper for Ipopt.
Summary/Motivation:
Users should expect consistent behavior.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: