Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate bounds relaxation for WaterTAP Ipopt #1140

Closed
wants to merge 51 commits into from

Conversation

bknueven
Copy link
Contributor

@bknueven bknueven commented Sep 20, 2023

Fixes/Resolves: N/A

@avdudchenko reports in consistencies in the way domain=pyo.NonNegativeReals vs bounds=(0, None). I tracked this down to an issue in the way "bounds relaxation" is handled in the WaterTAP wrapper for Ipopt.

This PR would resolve this issue by turning off bounds relaxation altogether for the WaterTAP wrapper for Ipopt.

Summary/Motivation:

Users should expect consistent behavior.

Changes proposed in this PR:

  • Turn off bounds relaxation for WaterTAP
  • Update some testing baselines.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bknueven bknueven changed the title [WIP] try reducing bounds overrelaxation Eliminate bounds relaxation for WaterTAP Ipopt Sep 21, 2023
@bknueven bknueven added Priority:High High Priority Issue or PR bugfix labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants