Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSM2 GUI Variable Name Update #1171

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

MarcusHolly
Copy link
Contributor

Fixes/Resolves:

Remaining checkbox in #1153

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added Priority:Normal Normal Priority Issue or PR ui labels Oct 16, 2023
@MarcusHolly MarcusHolly self-assigned this Oct 16, 2023
@MarcusHolly MarcusHolly marked this pull request as ready for review October 16, 2023 15:28
Copy link
Contributor

@luohezhiming luohezhiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcusHolly MarcusHolly linked an issue Oct 16, 2023 that may be closed by this pull request
6 tasks
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @MichaelPesce @dangunter we realized that when looking at sweep results, if we weren't particular about naming the output, there could be confusion between multiple outputs with the same name. For example, a concentration at the outlet of one unit should be distinguished from the same component concentration at the outlet of a different unit in the flowsheet.

TLDR: @MarcusHolly manually added category names in front of reported variable names to be able to distinguish between results. However, it might be better if this could be handled in the UI (i.e., for sweep results, display category and name for each entry).

@adam-a-a adam-a-a merged commit b866c12 into watertap-org:main Oct 16, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSM2 GUI Flowsheet
4 participants