You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to add OARO 1D model for issue #1131
This PR inherits @bknueven previous revisions of initialization routine #848 and make all tests passed.
Summary/Motivation:
Create OARO 1D model
Changes proposed in this PR:
add OARO 1D model
add tests
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
@luohezhiming just realized my last comment still would need to be addressed, but we can do that in a subsequent PR. I'll create an issue to track adding/updating OARO documentation
@luohezhiming - since we merged the SKK PR in first, that is breaking tests here. Hopefully, it's as easy as increasing the number of config options expected and nothing more than that.
@luohezhiming just realized my last comment still would need to be addressed, but we can do that in a subsequent PR. I'll create an issue to track adding/updating OARO documentation
Hi, Adam. I've already updated the issue for documentation in issue #1131
@luohezhiming - since we merged the SKK PR in first, that is breaking tests here. Hopefully, it's as easy as increasing the number of config options expected and nothing more than that.
@luohezhiming just realized my last comment still would need to be addressed, but we can do that in a subsequent PR. I'll create an issue to track adding/updating OARO documentation
Hi, Adam. I've already updated the issue for documentation in issue #1131
Thanks for the reminder! I forgot about that. Deleting the redundant issue that I created then.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
This PR is to add OARO 1D model for issue #1131
This PR inherits @bknueven previous revisions of initialization routine #848 and make all tests passed.
Summary/Motivation:
Create OARO 1D model
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: