BSM2 Anoxic CSTR Costing #1186

MarcusHolly · 2023-11-07T14:45:10Z

Summary/Motivation:

Adds costing method for anoxic CSTRs

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

watertap/costing/unit_models/cstr.py

luohezhiming

Probably we want to add a testing file for the costing, rather than direclty add to the current BSM2 cause other unit models' costings are still pending.

MarcusHolly · 2023-11-07T15:46:28Z

Probably we want to add a testing file for the costing, rather than directly add to the current BSM2 cause other unit models' costings are still pending.

I could be wrong, but I don't think we have tests for any of the other costing models? I don't see an obvious problem with just adding costing to the BSM2 flowsheet piece-by-piece

luohezhiming · 2023-11-07T15:48:53Z

Probably we want to add a testing file for the costing, rather than directly add to the current BSM2 cause other unit models' costings are still pending.

I could be wrong, but I don't think we have tests for any of the other costing models? I don't see an obvious problem with just adding costing to the BSM2 flowsheet piece-by-piece

The other costing tests are within their specific test files, like if you check test_electroNP_ZO.py, there is a test for costing

MarcusHolly · 2023-11-07T15:53:33Z

Probably we want to add a testing file for the costing, rather than directly add to the current BSM2 cause other unit models' costings are still pending.

I could be wrong, but I don't think we have tests for any of the other costing models? I don't see an obvious problem with just adding costing to the BSM2 flowsheet piece-by-piece

The other costing tests are within their specific test files, like if you check test_electroNP_ZO.py, there is a test for costing

Would that belong in WaterTAP or IDAES tho? For example, the HEX and mixer are IDAES models that we added WaterTAP costing for, and neither of these models have tests associated with them from what I can see. Although maybe we should add tests for these...

watertap/examples/flowsheets/case_studies/full_water_resource_recovery_facility/BSM2.py

bknueven · 2023-11-07T16:53:21Z

Would that belong in WaterTAP or IDAES tho? For example, the HEX and mixer are IDAES models that we added WaterTAP costing for, and neither of these models have tests associated with them from what I can see. Although maybe we should add tests for these...

The test should be in WaterTAP, probably in the costing directory.

There's not a test for the Mixer because we never wrote one. There's an open issue (#1187) to make sure all the costing methods have a unit test. Most do, but a few do not.

watertap/costing/unit_models/cstr.py

MarcusHolly · 2023-11-20T22:16:10Z

@bknueven I'll make your cost_by_flow_volume change, but do you know why the UI tests are failing in the linux builds? Maybe this is more of a question for Dan...

adam-a-a · 2023-11-22T18:04:44Z

watertap/unit_models/cstr.py

+#
+###############################################################################
+"""
+Anoxic CSTR unit model for BSM2 and plant-wide wastewater treatment modeling.


Rename filename to anoxic_cstr instead of cstr. Either that, or rename the class which is currently named AnoxicCSTR. The only dilemma I see with this sort of naming is that anoxic is not anaerobic, technically. So maybe it makes more sense to rename the class as CSTR, which would just build on top of IDAES' CSTR and be the WaterTAP version,

adam-a-a · 2023-11-22T18:06:14Z

watertap/unit_models/cstr.py

+        # Call UnitModel.build to set up dynamics
+        super(AnoxicCSTRData, self).build()
+
+        self.HRT = Var(


I know that we used the acronym (HRT) in ZO models previously. I spelled it out in my recent PR and I think @agarciadiego did too. We should be consistent and spell it out here too.

adam-a-a

Looks good- just some quick changes needed

codecov · 2023-11-22T19:26:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f063c13) 90.75% compared to head (e92f616) 94.78%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
+ Coverage   90.75%   94.78%   +4.03%     
==========================================
  Files         352      355       +3     
  Lines       35446    35478      +32     
==========================================
+ Hits        32168    33628    +1460     
+ Misses       3278     1850    -1428

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ertap into anoxic_tank_cost

watertap/unit_models/cstr.py

watertap/unit_models/tests/test_cstr.py

adam-a-a · 2023-11-29T04:38:13Z

watertap/costing/unit_models/cstr.py

+def build_cstr_cost_param_block(blk):
+    # Source: https://www.fwrj.com/articles/9812.pdf
+    blk.sizing_cost = pyo.Var(
+        initialize=0.34,


This is the unit cost for the largest size shown in the range from the reference. Perhaps we should choose a value like the mean or median.

The reason I chose the largest size is because the flowrate in BSM2 actually goes way beyond the ranges listed in this reference. The largest flow in the reference is 100,000 GPD (378.5 m3/day) whereas the BSM2 feed flowrate is 20648 m3/day. So I didn't think it made sense to choose a mean or median value. Although if we intend on using this CSTR for non-BSM2 purposes, then it would make more sense to use an average value.

Fair enough!

adam-a-a · 2023-11-29T04:40:23Z

watertap/unit_models/tests/test_cstr.py

+
+        # Check solutions
+        assert pytest.approx(526.45, rel=1e-5) == value(m.fs.unit.costing.capital_cost)
+        assert pytest.approx(9.0847e-8, rel=1e-5) == value(m.fs.costing.LCOW)


THis is the only check failing (on Mac) which leads me to believe that a tweak in scaling might resolve. However, this LCOW is approximately 0, and I am not totally confident that the result should/would be that low.

Perhaps I'll try using the median value for the sizing cost above and see if this resolves the issue (although I'm not convinced it will).

It was actually just a unit/scaling problem. Once I specified that the inlet flowrate was in m3/s and corrected the LCOW value, the Mac failure resolved itself. I didn't change the unit cost value though... still not sure if using the average/median makes sense.

What was the unit/scaling problem?

I needed to specify the units of volumetric flow when I set the operating conditions in the test file

adam-a-a

LGTM!

agarciadiego

LGTM

MarcusHolly added 2 commits November 7, 2023 09:42

Add anoxic cstr costing

1245716

Add costing to BSM2 flowsheet

4fe4d9a

MarcusHolly added the Priority:Normal Normal Priority Issue or PR label Nov 7, 2023

MarcusHolly requested review from adam-a-a, bknueven, agarciadiego and luohezhiming November 7, 2023 14:45

MarcusHolly self-assigned this Nov 7, 2023

adam-a-a reviewed Nov 7, 2023

View reviewed changes

watertap/costing/unit_models/cstr.py Outdated Show resolved Hide resolved

MarcusHolly added 2 commits November 7, 2023 10:31

Fix pylint issue

a21cb8e

Add electricity intensity to system-level metrics in flowsheet

94ec318

luohezhiming reviewed Nov 7, 2023

View reviewed changes

adam-a-a reviewed Nov 7, 2023

View reviewed changes

watertap/examples/flowsheets/case_studies/full_water_resource_recovery_facility/BSM2.py Outdated Show resolved Hide resolved

bknueven mentioned this pull request Nov 10, 2023

Costing Unification: move from factor_total_investment to TIC #1175

Merged

MarcusHolly added 9 commits November 17, 2023 14:54

Merge branch 'main' into anoxic_tank_cost

e7a9539

Add CSTR unit model based on IDAES CSTR

6658fa9

Update CSTR costing method

dbb3211

Use new CSTR model in BSM2 flowsheet

e1477bf

Add tests for CSTR unit model

816409d

Ignore mixer costs in BSM2 flowsheet for now

82e719f

Merge branch 'main' into anoxic_tank_cost

fbcc50b

Remove unused imports

228d8fe

Address pylint issue

9e18c86

MarcusHolly marked this pull request as ready for review November 20, 2023 15:09

MarcusHolly added 2 commits November 20, 2023 10:25

Add default costing method for cstr

835d9a8

Add LCOW into cost testing

df546bc

bknueven reviewed Nov 20, 2023

View reviewed changes

watertap/costing/unit_models/cstr.py Outdated Show resolved Hide resolved

MarcusHolly added 2 commits November 20, 2023 17:19

Use cost_by_flow_volume utility function

af96904

Revert changes made to BSM2 flowsheet

390eb5a

MarcusHolly marked this pull request as ready for review November 21, 2023 18:44

MarcusHolly mentioned this pull request Nov 21, 2023

Add Costing to BSM2 Flowsheet #1213

Merged

Merge branch 'main' into anoxic_tank_cost

9e2b42b

adam-a-a reviewed Nov 22, 2023

View reviewed changes

adam-a-a requested changes Nov 22, 2023

View reviewed changes

MarcusHolly added 2 commits November 27, 2023 08:31

Address Adam's comments

55c4503

Merge branch 'anoxic_tank_cost' of https://github.com/MarcusHolly/wat…

fb2a438

…ertap into anoxic_tank_cost

MarcusHolly requested a review from adam-a-a November 27, 2023 13:58

MarcusHolly commented Nov 27, 2023

View reviewed changes

watertap/unit_models/cstr.py Show resolved Hide resolved

Update class name/import

b9d2c71

adam-a-a mentioned this pull request Nov 27, 2023

Costing in BSM2 #1217

Closed

8 tasks

Address merge conflict

5babe49

adam-a-a reviewed Nov 29, 2023

View reviewed changes

watertap/unit_models/tests/test_cstr.py Show resolved Hide resolved

adam-a-a reviewed Nov 29, 2023

View reviewed changes

Make units explicit in unit costing test

fc56ef6

MarcusHolly requested a review from adam-a-a November 29, 2023 14:44

MarcusHolly and others added 2 commits November 30, 2023 09:28

Add check asserting units are consistent

d49433b

Merge branch 'main' into anoxic_tank_cost

c06f4a5

adam-a-a approved these changes Dec 5, 2023

View reviewed changes

agarciadiego approved these changes Dec 5, 2023

View reviewed changes

Merge branch 'main' into anoxic_tank_cost

e92f616

adam-a-a enabled auto-merge (squash) December 5, 2023 18:15

adam-a-a merged commit 35e90bd into watertap-org:main Dec 5, 2023
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BSM2 Anoxic CSTR Costing #1186

BSM2 Anoxic CSTR Costing #1186

MarcusHolly commented Nov 7, 2023 •

edited

Loading

luohezhiming left a comment

MarcusHolly commented Nov 7, 2023

luohezhiming commented Nov 7, 2023

MarcusHolly commented Nov 7, 2023

bknueven commented Nov 7, 2023 •

edited

Loading

MarcusHolly commented Nov 20, 2023

adam-a-a Nov 22, 2023

adam-a-a Nov 22, 2023

adam-a-a left a comment

codecov bot commented Nov 22, 2023 •

edited

Loading

adam-a-a Nov 29, 2023

MarcusHolly Nov 29, 2023

adam-a-a Dec 5, 2023

adam-a-a Nov 29, 2023

MarcusHolly Nov 29, 2023 •

edited

Loading

MarcusHolly Nov 29, 2023 •

edited

Loading

adam-a-a Dec 5, 2023

MarcusHolly Dec 5, 2023

adam-a-a left a comment

agarciadiego left a comment

BSM2 Anoxic CSTR Costing #1186

BSM2 Anoxic CSTR Costing #1186

Conversation

MarcusHolly commented Nov 7, 2023 • edited Loading

Summary/Motivation:

Legal Acknowledgement

luohezhiming left a comment

Choose a reason for hiding this comment

MarcusHolly commented Nov 7, 2023

luohezhiming commented Nov 7, 2023

MarcusHolly commented Nov 7, 2023

bknueven commented Nov 7, 2023 • edited Loading

MarcusHolly commented Nov 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adam-a-a left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 22, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcusHolly Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

MarcusHolly Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adam-a-a left a comment

Choose a reason for hiding this comment

agarciadiego left a comment

Choose a reason for hiding this comment

MarcusHolly commented Nov 7, 2023 •

edited

Loading

bknueven commented Nov 7, 2023 •

edited

Loading

codecov bot commented Nov 22, 2023 •

edited

Loading

MarcusHolly Nov 29, 2023 •

edited

Loading

MarcusHolly Nov 29, 2023 •

edited

Loading