Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chemistry tests #1229

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Conversation

bknueven
Copy link
Contributor

Fixes/Resolves N/A

Summary/Motivation:

The water chemistry tests based the Generic Reaction / Parameter Blocks have been a pain to maintain, and do not seem to be of importance anymore. This PR would remove these tests.

Changes proposed in this PR:

  • Remove the directory watertap/examples/chemistry

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66eb651) 94.80% compared to head (dc55462) 94.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
- Coverage   94.80%   94.78%   -0.03%     
==========================================
  Files         354      353       -1     
  Lines       35515    35454      -61     
==========================================
- Hits        33669    33604      -65     
- Misses       1846     1850       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see them go, but I understand.

@bknueven bknueven enabled auto-merge (squash) December 2, 2023 01:56
@bknueven bknueven merged commit 86301bc into watertap-org:main Dec 2, 2023
24 checks passed
@TimBartholomew TimBartholomew mentioned this pull request Dec 12, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants