Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idaes-pse requirement in preparation of 2.3.0 release #1241

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Summary/Motivation

  • Upcoming release of IDAES

Changes proposed in this PR:

  • Update idaes-pse requirement(s) in setup.py

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Dec 7, 2023
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Dec 7, 2023
Copy link
Contributor

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7e70cc) 94.84% compared to head (b0d5471) 94.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files         356      356           
  Lines       35766    35766           
=======================================
  Hits        33922    33922           
  Misses       1844     1844           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bknueven bknueven marked this pull request as ready for review December 8, 2023 03:24
@bknueven bknueven enabled auto-merge (squash) December 8, 2023 03:24
@bknueven bknueven merged commit 06149c9 into watertap-org:main Dec 8, 2023
24 checks passed
hunterbarber added a commit to hunterbarber/watertap that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants