Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OARO 1D documentation #1261

Merged
merged 69 commits into from
Dec 31, 2023
Merged

OARO 1D documentation #1261

merged 69 commits into from
Dec 31, 2023

Conversation

luohezhiming
Copy link
Contributor

Fixes/Resolves:

(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)

Summary/Motivation:

Add documentation for OARO1d model

Changes proposed in this PR:

  • add oaro1d doc
  • revise oaro0d doc to be consistent with the current settings

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0454198) 94.24% compared to head (0a1bbf7) 94.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1261   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files         360      360           
  Lines       36276    36276           
=======================================
  Hits        34188    34188           
  Misses       2088     2088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-a-a adam-a-a merged commit 65f9749 into watertap-org:main Dec 31, 2023
24 checks passed
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jan 4, 2024
@ksbeattie ksbeattie mentioned this pull request Jan 4, 2024
6 tasks
lbianchi-lbl pushed a commit that referenced this pull request Jan 26, 2024
* add

* delete redundant files

* add oaro 1d documentation

(cherry picked from commit 65f9749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants