Add functionality for input based model options #1270
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 367 367
Lines 37234 37259 +25
=======================================
+ Hits 35105 35131 +26
+ Misses 2129 2128 -1 ☔ View full report in Codecov by Sentry. |
watertap/ui/fsapi.py
Outdated
| @@ -611,6 +631,14 @@ def __init__( | |||
| self.add_action("diagram", None) | |||
|
|
|||
| self._actions["custom_do_param_sweep_kwargs"] = custom_do_param_sweep_kwargs | |||
| self.fs_exp.add_option( | |||
| name="NumParallelWorkers", | |||
| display_name="Number of multi-processing workers", | |||
There was a problem hiding this comment.
It might be more clear to say "Number of multi-processing workers for sensitivity analysis"
right now when there are build options, we don't have a way to do any groupings. Might be nice if we had a groups for build options like we do for flowsheet inputs (e.g. flowsheet model build options, analysis options etc..)
There was a problem hiding this comment.
I think @MichaelPesce mentioned that he would exclude this bit from the PR
| @@ -218,11 +220,29 @@ def validate_description(cls, v, values): | |||
| @classmethod | |||
| def validate_value(cls, v, values): | |||
There was a problem hiding this comment.
If I read this right, we can allow users select an option from a list, or enter a string, int or float?
There was a problem hiding this comment.
That's true according to @MichaelPesce
Fixes/Resolves:
Addresses issue #1239 and UI issue watertap-org/watertap-ui#98
Summary/Motivation:
Allow for flowsheets to have model options that take string, integer, or float types as the value.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: