-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to GAC model and GAC example flowsheet to solve when MaterialFlowBasis.mass
#1295
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 94.39% 94.38% -0.01%
==========================================
Files 371 371
Lines 37922 37941 +19
==========================================
+ Hits 35795 35812 +17
- Misses 2127 2129 +2 ☔ View full report in Codecov by Sentry. |
f828f27
to
6c80edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small type in the UI - otherwise LGTM
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes/Resolves:
Changes to GAC model and GAC example flowsheet to solve when
MaterialFlowBasis.mass
Summary/Motivation:
Improve GAC functionality with newer MCAS flow basis options
Changes proposed in this PR:
MaterialFlowBasis.mass
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: