-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validity ranges and clean up water_prop_pack, seawater_prop_pack, and NaCl_T_dep_prop_pack #1304
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1304 +/- ##
==========================================
- Coverage 94.25% 94.25% -0.01%
==========================================
Files 370 370
Lines 37951 37950 -1
==========================================
- Hits 35769 35768 -1
Misses 2182 2182 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Adam Atia <aatia@keylogic.com>
Co-authored-by: Adam Atia <aatia@keylogic.com>
@savannahsakhai I think we can reserve the inclusion of saturation temperature and temperature-dependent diffusivity in a separate PR since we are prepping for a release and can get these straightforward changes in in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to comment clean up are good. Convert any feature requests to corresponding issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes/Resolves:
Summary/Motivation:
This PR cleans up three of the property models by reformatting the in-code citations and adding validity ranges for each of the properties.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: