Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electrolyzer Test Harness #1321

Merged

Conversation

hunterbarber
Copy link
Contributor

Fixes/Resolves:

Electrolyzer test harness

Summary/Motivation:

#1302

Changes proposed in this PR:

  • Adds electrolyzer test harness
  • Separates costing into temporary cost test file
  • Minor change removing duplicated code in the GAC test temporary file

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@hunterbarber hunterbarber self-assigned this Mar 4, 2024
@hunterbarber hunterbarber added the Priority:High High Priority Issue or PR label Mar 4, 2024
@hunterbarber hunterbarber mentioned this pull request Mar 4, 2024
22 tasks
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (fe886b4) to head (ce6ac28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
- Coverage   94.39%   94.39%   -0.01%     
==========================================
  Files         371      371              
  Lines       37922    37922              
==========================================
- Hits        35796    35795       -1     
- Misses       2126     2127       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@savannahsakhai savannahsakhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo otherwise LGTM

watertap/costing/unit_models/tests/test_electrolyzer.py Outdated Show resolved Hide resolved
@lbianchi-lbl lbianchi-lbl merged commit 44468b7 into watertap-org:main Mar 6, 2024
24 checks passed
@hunterbarber hunterbarber deleted the electrolyzer_test_harness branch March 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants