Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves compressor initialization #1350

Merged
merged 11 commits into from
Apr 12, 2024

Conversation

ElmiraShamlou
Copy link
Contributor

Fixes/Resolves: issue #968

(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (c93438e) to head (8acb652).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
+ Coverage   93.83%   93.84%   +0.01%     
==========================================
  Files         337      337              
  Lines       35290    35298       +8     
==========================================
+ Hits        33114    33126      +12     
+ Misses       2176     2172       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElmiraShamlou ElmiraShamlou marked this pull request as ready for review April 1, 2024 16:52
@ElmiraShamlou ElmiraShamlou linked an issue Apr 4, 2024 that may be closed by this pull request
@ElmiraShamlou ElmiraShamlou self-assigned this Apr 4, 2024
@ElmiraShamlou ElmiraShamlou added the Priority:Normal Normal Priority Issue or PR label Apr 11, 2024
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie requested a review from adam-a-a April 11, 2024 20:32
@adam-a-a adam-a-a added the nawi label Apr 11, 2024
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bknueven bknueven merged commit 73c4bc3 into watertap-org:main Apr 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nawi Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVC test compressor unit fails to initialize
6 participants