Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idaes-pse requirement to support Pyomo 6.7.2 #1381

Merged
merged 2 commits into from
May 10, 2024

Conversation

lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented May 8, 2024

Summary/Motivation:

Test compatibility of upcoming Pyomo and/or IDAES releases
Ensure compatibility of IDAES with Pyomo 6.7.2 by updating idaes-pse requirement to a version that includes IDAES/idaes-pse#1402

Next steps

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this May 8, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (38735ec) to head (6adff0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         339      339           
  Lines       35890    35890           
=======================================
  Hits        33682    33682           
  Misses       2208     2208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label May 9, 2024
@lbianchi-lbl lbianchi-lbl added Priority:High High Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels May 9, 2024
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review May 9, 2024 21:59
@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) May 9, 2024 22:00
@lbianchi-lbl lbianchi-lbl changed the title Update idaes-pse requirement to test pyomo 6.7.2 and/or IDAES 2.5 Update idaes-pse requirement to support Pyomo 6.7.2 May 9, 2024
@lbianchi-lbl lbianchi-lbl merged commit 63564d8 into watertap-org:main May 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: metaclass conflict failures with Pyomo 6.7.2, IDAES 2.4.0
4 participants