-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Model Demo Rework #1390
Custom Model Demo Rework #1390
Conversation
@lbianchi-lbl Do you know how I can resolve this notebook failure? |
The kernelspec name should be changed to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
===========================================
+ Coverage 41.15% 93.92% +52.76%
===========================================
Files 97 335 +238
Lines 10572 35620 +25048
===========================================
+ Hits 4351 33456 +29105
+ Misses 6221 2164 -4057 ☔ View full report in Codecov by Sentry. |
This is great, @MarcusHolly ! Good timing as we are aiming to spruce up tutorials and possibly use for upcoming workshops. I am thinking about whether we should bring in #1178 or this first. #1178 adds a landing page for all tutorials, and I repaired/renamed some tutorials that we have now. Maybe this one first, then I can add these new tutorials to the landing page. Thoughts @MarcusHolly @zacharybinger @ElmiraShamlou @kurbansitterley @luohezhiming ? |
@adam-a-a I agree - I think we can merge this one first and then update #1178 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This is a priority as it may come in handy for upcoming workshop. I did not thoroughly check for typos, so if second reviewer could do that, that would be much appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I did not see any typos.
Summary/Motivation:
Revamps the files previously living in the custom model demo folder to function as proper tutorials inside of Jupyter Notebook
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: