-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Costing Doc Automation #1394
Update Costing Doc Automation #1394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MarcusHolly I think you're the author of all the existing cost docs in main as of now which already have this change applied? |
I also didn't touch documentation that are currently in open PRs (GAC, Electrolyzer, and crystallizer), but those all adhere to this format now as well |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 335 335
Lines 35620 35620
=======================================
Hits 33491 33491
Misses 2129 2129 ☔ View full report in Codecov by Sentry. |
…Holly/watertap into costing_automation_update
Summary/Motivation:
In the unit model costing documentation there was a column named "Default Value" under the Costing Method Variables section. Since this column does not make sense for many of these variables, this column has been changed to "Index". This PR also changes the variable and parameter names to the monospacing font to distinguish them from regular text.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: