-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowsheet documentation for NaCl crystallizer #1403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 335 335
Lines 35620 35620
=======================================
Hits 33491 33491
Misses 2129 2129 ☔ View full report in Codecov by Sentry. |
Documentation for the crystallizer unit model can be found below. | ||
* `Crystallizer <https://watertap.readthedocs.io/en/latest/technical_reference/unit_models/crystallizer_0D.html>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing I missed in my review - you should also provide a link here to the crystallization property package. Although it looks like there's no documentation for this yet... I think it'd be nice to have this for the 1.0 release, so maybe it's best to address this in a separate PR that also adds the prop pack documentation.
Fixes/Resolves:
NaCl crystallizer flowsheet documentation for #1219
Summary/Motivation:
Adding NaCl crystallizer flowsheet documentation
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: