Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy WT3 data files #1422

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

kurbansitterley
Copy link
Contributor

@kurbansitterley kurbansitterley commented May 31, 2024

Fixes/Resolves:

Removes old WT3 data files (.csvs) that were buried in the case_studies directory.
Possibly part of #1248 ??

Summary/Motivation:

As far as I can tell, these .csvs were not used in any unit model or example/demonstration. I assume we kept them around just as a reference as we were porting the WT3 models into WaterTAP, but they are not needed anymore so could be confusing to someone poking around the examples folder. Also, based on some of the entries, they appear to be copies of versions I had on my local machine at the time of the merger... I am not sure how that happened. Their purpose for being in the watertap repo is not documented anywhere. Their origin is not documented anywhere. Just a couple of random .csvs floating in the ether...

If ever they are needed again, they are available here: https://github.com/NREL/WaterTAP3

Changes proposed in this PR:

  • Removes from WaterTAP old legacy WT3 .csvs that are not used for anything.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (271e43b) to head (e907ccf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1422   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files         335      335           
  Lines       35561    35561           
=======================================
  Hits        33431    33431           
  Misses       2130     2130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I was not even aware these files existed

@bknueven bknueven enabled auto-merge (squash) June 4, 2024 17:43
@bknueven bknueven merged commit 4f54f18 into watertap-org:main Jun 4, 2024
23 of 24 checks passed
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR wt3 migration WaterTAP3 merger work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants