Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code, docs, and references for EDB #1432

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

lbianchi-lbl
Copy link
Contributor

Summary/Motivation:

Changes proposed in this PR:

  • Remove Python code under watertap/edb
  • Remove EDB examples
  • Remove EDB doc pages
  • Remove references to EDB from other doc pages

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review June 10, 2024 22:54
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (03edf81) to head (8176327).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
+ Coverage   93.72%   93.94%   +0.21%     
==========================================
  Files         322      311      -11     
  Lines       34455    33151    -1304     
==========================================
- Hits        32294    31143    -1151     
+ Misses       2161     2008     -153     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl added 1.0 Hard requirement for the 1.0 release Priority:Normal Normal Priority Issue or PR labels Jun 11, 2024
@lbianchi-lbl lbianchi-lbl self-assigned this Jun 11, 2024
@ksbeattie ksbeattie self-requested a review June 13, 2024 20:33
Copy link
Contributor

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) June 14, 2024 00:12
@lbianchi-lbl lbianchi-lbl merged commit 41b6ae3 into watertap-org:main Jun 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Hard requirement for the 1.0 release Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants