Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding anaerobic digester cost #1433

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Conversation

agarciadiego
Copy link
Contributor

Fixes/Resolves:

Addresses #1360 for Anaerobic Digester

Summary/Motivation:

Required for WaterTap 1.0

Changes proposed in this PR:

  • Adds documentation for anaerobic digester

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@agarciadiego agarciadiego added documentation Improvements or additions to documentation Priority:Normal Normal Priority Issue or PR 1.0 Hard requirement for the 1.0 release labels Jun 11, 2024
@agarciadiego agarciadiego self-assigned this Jun 11, 2024
@agarciadiego agarciadiego marked this pull request as draft June 11, 2024 14:22
@agarciadiego agarciadiego mentioned this pull request Jun 11, 2024
28 tasks
@agarciadiego agarciadiego marked this pull request as ready for review June 11, 2024 14:27
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos

docs/technical_reference/costing/anaerobic_digester.rst Outdated Show resolved Hide resolved
docs/technical_reference/costing/anaerobic_digester.rst Outdated Show resolved Hide resolved
docs/technical_reference/costing/anaerobic_digester.rst Outdated Show resolved Hide resolved
docs/technical_reference/costing/anaerobic_digester.rst Outdated Show resolved Hide resolved
agarciadiego and others added 4 commits June 11, 2024 10:35
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
Co-authored-by: luohezhiming <98901358+luohezhiming@users.noreply.github.com>
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (41b6ae3) to head (78bdb13).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files         311      311           
  Lines       33151    33151           
=======================================
  Hits        31143    31143           
  Misses       2008     2008           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bknueven bknueven merged commit 193f385 into watertap-org:main Jun 21, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Hard requirement for the 1.0 release costing documentation Improvements or additions to documentation Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants