Update idaes-pse requirement for current dev version to latest tag on watertap-org fork #289
Conversation
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 79 79
Lines 8362 8362
=======================================
Hits 7510 7510
Misses 852 852 Continue to review full report at Codecov.
|
|
@lbianchi-lbl the new tag points to the same IDAES commit as the old tag: watertap-org/idaes-pse@2021d13. |
|
@bknueven You're absolutely right, thanks for catching that. I must have done the tag creation and pull in the wrong order. I'll recreate the tag and re-run the tests again. |
|
Revoking my approval due to a test failure after updated tag. @adam-a-a @TimBartholomew The failure is in the NaCl and Seawater prop packages. So far, none of the chem tests have failed that I can see. |
There was a problem hiding this comment.
NaCl and Seawater Prop Packages are failing
===========================
FAILED watertap/property_models/tests/test_NaCl_prop_pack.py::TestNaClProperty_idaes::test_initialize_failure
FAILED watertap/property_models/tests/test_seawater_prop_pack.py::TestSeawaterProperty_idaes::test_initialize_failure
|
wrong Andrew Lee
…On Thu, Jan 6, 2022 at 1:53 PM Ludovico Bianchi ***@***.***> wrote:
Summary/Motivation:
- Set the idaes-pse requirement to the current main of
IDAES/idaes-pse, which incorporated the fixes that should address most of
the issues in #287
<#287>
- @AndrewLee <https://github.com/AndrewLee> will address 2 of the
remaining test failures, which should leave only one expected test failure
to be fixed on the WaterTAP side
Legal Acknowledgement
By contributing to this software project, I agree to the following terms
and conditions for my contribution:
1. I agree my contributions are submitted under the license terms
described in the LICENSE.txt file at the top level of this directory.
2. I represent I am authorized to make the contributions and grant the
license. If my employer has rights to intellectual property that includes
these contributions, I represent that I have received permission to make
contributions and grant the required license on behalf of that employer.
------------------------------
You can view, comment on, or merge this pull request online at:
#289
Commit Summary
- a78c9b0
<a78c9b0>
Update idaes-pse requirement to latest tag
File Changes
(1 file <https://github.com/watertap-org/watertap/pull/289/files>)
- *M* setup.py
<https://github.com/watertap-org/watertap/pull/289/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7>
(2)
Patch Links:
- https://github.com/watertap-org/watertap/pull/289.patch
- https://github.com/watertap-org/watertap/pull/289.diff
—
Reply to this email directly, view it on GitHub
<#289>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHBWLC6ZWIRSZKS5ZQILTUUYFLVANCNFSM5LNJ2SMA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The failures in the NaCl and seawater property package are the ones I was expecting to see - I will fix these today, |
|
@aladshaw3 this should auto-merge as soon as the requested changes in your review are marked as addressed:
|
… watertap-org fork (#289) * Update idaes-pse requirement to latest tag * Adding InitializationErrors to watertap propery packages * Fixing issue with initialization errors when solve wa skipped Co-authored-by: Austin Ladshaw <ladshawap@ornl.gov> Co-authored-by: Andrew Lee <andrew.lee@netl.doe.gov> (cherry picked from commit e1641cb)
Summary/Motivation:
mainof IDAES/idaes-pse, which incorporated the fixes that should address most of the issues in WaterTAP test failures with current IDAES main (1.13.dev) and 1.12.0 release #287Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: