fix lvmd connection leak

wavezhang · Jul 16, 2018 · 423dcfa · 423dcfa
1 parent 75fe2de
commit 423dcfa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/pkg/lvm/controllerserver.go b/pkg/lvm/controllerserver.go
@@ -80,6 +80,7 @@ func (cs *controllerServer) DeleteVolume(ctx context.Context, req *csi.DeleteVol
 		}
 
 		conn, err := lvmd.NewLVMConnection(addr, connectTimeout)
+		defer conn.Close()
 		if err != nil {
 			return nil, status.Error(codes.Internal, fmt.Sprintf("Failed to connect to %v: %v", addr, err))
 		}

diff --git a/pkg/lvm/nodeserver.go b/pkg/lvm/nodeserver.go
@@ -70,6 +70,7 @@ func (ns *nodeServer) createVolume(ctx context.Context, volumeId string) (*v1.Pe
 	}
 
 	conn, err := lvmd.NewLVMConnection(addr, connectTimeout)
+	defer conn.Close()
 	if err != nil {
 		return nil, status.Errorf(codes.Internal, fmt.Sprintf("Failed to connect to %v: %v", addr, err))
 	}