Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer should be a dev dependency, not an optional dependency #66

Closed
ngyikp opened this issue Mar 13, 2018 · 1 comment
Closed

Puppeteer should be a dev dependency, not an optional dependency #66

ngyikp opened this issue Mar 13, 2018 · 1 comment

Comments

@ngyikp
Copy link

ngyikp commented Mar 13, 2018

Installing webpack-subresource-integrity@1.1.0-rc.2 as a dependency would install Puppeteer unnecessarily and bloat node_modules size, Puppeteer should be included as a dev dependency instead.

@jscheid
Copy link
Collaborator

jscheid commented Mar 13, 2018

Thanks for the bug report. You're right, I'll change it and aim to release in 1.1.0-rc.3 sometime soon.

(Ideally it would be in "optional dev dependencies" but there is no such thing. npm/npm#3870 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants