Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter ossec_rootcheck_ignore_list #212

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

Hexta
Copy link

@Hexta Hexta commented Feb 14, 2020

Add a parameter wazuh::manager::ossec_rootcheck_ignore_list.

@Hexta Hexta requested a review from jm404 February 14, 2020 09:09
Add parameters:
 - wazuh::manager::ossec_rootcheck_ignore_list
 - wazuh::agent::ossec_rootcheck_ignore_list
@Hexta
Copy link
Author

Hexta commented Feb 26, 2020

Could anybody please take a look at the PR?

@manuasir
Copy link
Contributor

Hey @Hexta , sorry for the late response. Let us give a try to this, launch the tests and if everything fine it'll be shipped.

Thank you for contributing!

@manuasir manuasir changed the base branch from master to devel February 26, 2020 17:18
@rshad
Copy link
Contributor

rshad commented Mar 3, 2020

Hi @Hexta !

Thank you for contributing for Wazuh, it's really appreciated.

I'll review your changes and test them. I'll be back soon.

Kr,

Rshad

@rshad rshad self-assigned this Mar 3, 2020
@rshad rshad self-requested a review March 3, 2020 11:45
@rshad
Copy link
Contributor

rshad commented Mar 6, 2020

Hi!

Puppet Lint Validation Log

root@07aa15b95580:~/wazuh-puppet# pdk validate
pdk (INFO): Using Ruby 2.5.7
pdk (INFO): Using Puppet 6.13.0
pdk (INFO): Running all available validators...
┌ [✔] Running metadata validators ...
├── [✔] Checking metadata syntax (metadata.json tasks/*.json).
└── [✔] Checking module metadata style (metadata.json).
┌ [✔] Running puppet validators ...
├── [✔] Checking Puppet manifest syntax (**/*.pp).
└── [✔] Checking Puppet manifest style (**/*.pp).
┌ [✔] Running ruby validators ...
└── [✔] Checking Ruby code style (**/**.rb).
┌ [✔] Running tasks validators ...
├── [✔] Checking task names (tasks/**/*).
└── [✔] Checking task metadata style (tasks/*.json).
┌ [✔] Running yaml validators ...
└── [✔] Checking YAML syntax (**/*.yaml **/*.yml).
info: puppet-epp: ./: Target does not contain any files to validate (["**/*.epp"]).
info: task-name: ./: Target does not contain any files to validate (["tasks/**/*"]).
info: task-metadata-lint: ./: Target does not contain any files to validate (["tasks/*.json"]).root@07aa15b95580:~/wazuh-puppet# git branch
* Hexta/master
  master
root@07aa15b95580:~/wazuh-puppet#

Kr,

Rshad

@rshad rshad merged commit 8c3d076 into wazuh:devel Mar 6, 2020
@rshad
Copy link
Contributor

rshad commented Mar 6, 2020

Hi @Hexta!

Thank you again for contributing to Wazuh.

Kr,

Rshad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants