Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update target name in concat for manager_ossec.conf #341

Merged
merged 7 commits into from
Jan 14, 2021
Merged

Conversation

Zenidd
Copy link
Contributor

@Zenidd Zenidd commented Jan 14, 2021

This PR was originally opened by @g3rhard. Below the original description.

Hello everyone! I think, I fix issue #322 by simple changing concat target in few classes.

Here is working example:

  wazuh::addlog { 'CronLogFile':
    logfile => '/var/log/cron.log',
    logtype => 'syslog'
  }

  wazuh::email_alert { 'mail':
    alert_email => 'mail@example.com',
    alert_group => ['syslog'],
  }

  wazuh::activeresponse { 'blockWebattack':
    active_response_command            => 'firewall-drop',
    active_response_level              => 9,
    active_response_agent_id           => 123,
    active_response_rules_id           => [31153,31151],
    active_response_repeated_offenders => ['30','60','120'],
  }

  wazuh::command { 'firewallblock':
    command_name       => 'firewall-drop',
    command_executable => 'firewall-drop.sh',
    command_expect     => 'srcip'
  }

After changing everything work as expected.

@Zenidd Zenidd added community type/enhancement Enhacement or new feature labels Jan 14, 2021
@Zenidd Zenidd requested a review from xr09 January 14, 2021 14:33
@Zenidd
Copy link
Contributor Author

Zenidd commented Jan 14, 2021

Hey @g3rhard,

I just reopened the PR targeting the master branch (our current devel branch). I also wanted to use an internal branch so the tests run over your commits.

-JP

Copy link
Contributor

@xr09 xr09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zenidd Zenidd merged commit df7b051 into master Jan 14, 2021
@Zenidd Zenidd deleted the fixes-by-g3rard branch January 14, 2021 14:41
@g3rhard
Copy link
Contributor

g3rhard commented Jan 14, 2021

Thank you @Zenidd :)

@Zenidd
Copy link
Contributor Author

Zenidd commented Jan 14, 2021

Thanks again for the contribution @g3rhard, do not hesitate to open issues/PR's when you think there is something that can be improved.

-JP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community type/enhancement Enhacement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active-response, command and localfile options related manifests not working properly
3 participants