Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include WordPress-Extra ruleset #2

Closed
ocean90 opened this issue Jun 26, 2018 · 1 comment
Closed

Include WordPress-Extra ruleset #2

ocean90 opened this issue Jun 26, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@ocean90
Copy link
Member

ocean90 commented Jun 26, 2018

File: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/develop/WordPress-Extra/ruleset.xml

We should use the more stricter ruleset which is defined in WordPress-Extra. But not that strict like escaping all translations. Those should be excluded.

@swissspidy
Copy link
Contributor

Absolutely. I didn't add it the first time around because it usually generates a lot of false positives regarding unescaped output when adding to an existing project. You have to inspect each and every line to make sure it's safe.

Also, at least to some degree I want to include the WordPress-Docs ruleset as well. Our inline docs are often times really inconsistent, ranging from superb to non-existent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants