Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include WordPress-Extra ruleset #6

Merged
merged 4 commits into from
Jul 26, 2018
Merged

Include WordPress-Extra ruleset #6

merged 4 commits into from
Jul 26, 2018

Conversation

swissspidy
Copy link
Contributor

@swissspidy swissspidy commented Jun 28, 2018 •
edited
Loading

Fixes #2.

@swissspidy
Copy link
Contributor Author

swissspidy commented Jun 28, 2018 •
edited
Loading

Suggest adding this as well:

<rule ref="WordPress.Security.EscapeOutput">
	<properties>
		<property name="customEscapingFunctions" value="number_format_i18n,date_i18n,__,paginate_links" />
	</properties>
</rule>

@swissspidy
Copy link
Contributor Author

swissspidy commented Jun 28, 2018 •
edited
Loading

Looks like WPCS renamed WordPress.XSS to WordPress.Security in preparation for version 1.0

@swissspidy swissspidy mentioned this pull request Jun 28, 2018
Closed
1 task
@swissspidy swissspidy changed the title [WIP] Include WordPress-Extra ruleset Include WordPress-Extra ruleset Jun 28, 2018
@swissspidy swissspidy requested a review from ocean90 June 28, 2018 15:51
@swissspidy
Copy link
Contributor Author

Need to rename WordPress.Security to WordPress.XSS first to make it work.

When WPCS 1.0 is released, we can change it back.

Or we just wait.

@swissspidy
Copy link
Contributor Author

It has now been released! 🎉

See also #8.

@swissspidy swissspidy merged commit 7c6bdce into master Jul 26, 2018
@swissspidy swissspidy deleted the wordpress-extra branch July 26, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocean90 ocean90 ocean90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swissspidy @ocean90