This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Ignore order when comparing lists #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When patching an existing resource with `kubectl apply`, the ordering of certain lists (such as the containers in a deployment template) is not guaranteed to be preserved; this can result in spurious differences being detected as lists were compared strictly in order.
jml
reviewed
Apr 28, 2017
| del have[j] | ||
| break | ||
| else: | ||
| yield missing_item(path, "element [%d]" % i) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This was referenced May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When patching an existing resource with
kubectl apply, the ordering of certain lists (such as the containers in a deployment template) is not guaranteed to be preserved; this can result in spurious differences being detected as lists were compared strictly in order.A consequence of this patch is that differences in lists are now reported at the element level e.g.