Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Freshen Dockerfile #79

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Freshen Dockerfile #79

merged 2 commits into from
Apr 16, 2019

Conversation

damienleger
Copy link
Contributor

  • use last alpine image
  • use last kubectl cli
  • remove unnecessary make package

@damienleger
Update Dockerfile
b3f5f29 
- use last alpine image
- use last kubectl cli
- remove unnecessary make package
bboreham added a commit that referenced this pull request Feb 13, 2019
@bboreham
WIP fix #79
7fa999e
damienleger pushed a commit to mirakl/kubediff that referenced this pull request Mar 4, 2019
Mirakl fork
6e3fba8 
- Dockerfile freshen: fresher kubectl version and alpine base image (weaveworks#79)
- Makefile modified to build and push on Mirakl registry
- Display differences on containers subfields (weaveworks#37)
damienleger pushed a commit to mirakl/kubediff that referenced this pull request Mar 4, 2019
Mirakl fork
31adbb1 
- Dockerfile freshen: fresher kubectl version and alpine base image (weaveworks#79)
- Makefile modified to build and push on Mirakl registry
- Display differences on containers subfields and env var diff especially (weaveworks#37)
- Add key missing in wished configuration for .metadata.labels only
- Update build instructions
damienleger pushed a commit to mirakl/kubediff that referenced this pull request Mar 4, 2019
Mirakl fork
6256004 
- Dockerfile freshen: fresher kubectl version and alpine base image (weaveworks#79)
- Makefile modified to build and push on Mirakl registry
- Display differences on containers subfields and env var diff especially (weaveworks#37)
- Add key missing in wished configuration for .metadata.labels only
- Update build instructions
rade
rade reviewed Mar 6, 2019
View reviewed changes
Copy link
Member

@rade rade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the kubectl version bump prevent kubediff from working with older-version clusters?

@bboreham
Copy link
Contributor

bboreham commented Mar 6, 2019

Yes, I believe kubectl 1.9 stopped working with v1.5 servers.

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-cli/kubectl-conventions.md#principles:

We currently only guarantee one release of version skew is supported, but we strive to make old releases of kubectl continue to work with newer servers in compliance with our API compatibility guarantees.

@rade
Copy link
Member

rade commented Mar 6, 2019

Wouldn't it be prudent to bump kubectl to a less recent version, to retain better compatibility with older k8s?

1.11.x, perhaps?

@andrebriggs
Copy link

@rade what is the minimum version of Kubernetes server you want to support?

@damienleger any update?

@andrebriggs andrebriggs mentioned this pull request Apr 2, 2019
Closed
@bboreham
Copy link
Contributor

In view of no update, I'll push a commit moving it to 1.11.9

bboreham
bboreham approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@bboreham bboreham merged commit 1f04d09 into weaveworks:master Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rade rade rade left review comments

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damienleger @bboreham @rade @andrebriggs