Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added profiling docs #4089

Merged
merged 2 commits into from
Oct 19, 2023
Merged

added profiling docs #4089

merged 2 commits into from
Oct 19, 2023

Conversation

enekofb
Copy link
Contributor

@enekofb enekofb commented Oct 18, 2023

Part of weaveworks/weave-gitops-enterprise#3228

What changed?

How did you validate the change?

Developed locally

Screenshot 2023-10-18 at 12 01 51

@enekofb enekofb added the documentation Improvements or additions to documentation label Oct 18, 2023
@enekofb enekofb requested a review from a team October 18, 2023 11:02

### Profiling

Profiling can be useful during operation to help you to gain deeper understanding of the management cluster is behaving a runtime.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of the management cluster is behaving a runtime should it be of how the management cluster is behaving a runtime?

Go,profiling - a space before the comma is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated to make it a bit more clear.

Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments.

@enekofb enekofb merged commit 079801a into main Oct 19, 2023
30 checks passed
@enekofb enekofb deleted the add-profiling-docs branch October 19, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants