chore: add suggests and move reflection-docblock #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostdebruijn
force-pushed
the
joost/fix-dependencies
branch
from
b6bd0f7
to
42e0ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch: 4.8.x
Resolves issue: n/a
This one is based on my last comments in PR #560. The dependency
phpdocumentor/reflection-docblockmust be inrequireinstead ofrequire-dev, as this one is needed in production environments for the serializer which uses several classes from this package. In the original PR I added varioussuggest-entries to the webauth-lib sub repo which didn't get merged, however: they are needed there as well for serialization (they may even be arequire-dependency, but strictly it's not needed for all use cases).Sorry for being here again about the dependencies, don't hesitate just closing this one!