Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow paragonie/constant_time_encoding v3 #594

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

joostdebruijn
Copy link
Contributor

Target branch: v4.9.0
Resolves issue: n/a

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

This change allows paragonie/constant_time_encoding v3. The breaking change in v3 is that it supports only PHP v8.0 or higher. As this package requires PHP v8.1 or higher, that should not be a problem. Using v2 is still allowed, as paragonie/constant_time_encoding is widely used and may not be updated for other dependencies of a project. Therefore this will not be a breaking change for existing users of this library.

@Spomky Spomky merged commit 938e718 into web-auth:4.9.x Jun 14, 2024
11 of 14 checks passed
@Spomky
Copy link
Contributor

Spomky commented Jun 14, 2024

Many thanks

@joostdebruijn
Copy link
Contributor Author

@Spomky FYI: This one was missing in the changelog for release v4.9.0. I think because it's missing the milestone?

@Spomky Spomky added this to the 4.9.0 milestone Jul 12, 2024
@Spomky Spomky added the dependencies Pull requests that update a dependency file label Jul 12, 2024
@Spomky
Copy link
Contributor

Spomky commented Jul 12, 2024

Hello @joostdebruijn,

Indeed, I missed the milestone and the tags. Sorry for not doing so.
I just updated the release note.

@joostdebruijn joostdebruijn deleted the joost/chore-upgrade-cte branch July 12, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants