Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix test #4424

Merged
merged 2 commits into from
Aug 11, 2023
Merged

chore: fix test #4424

merged 2 commits into from
Aug 11, 2023

Conversation

zllkjc
Copy link
Member

@zllkjc zllkjc commented Aug 11, 2023

Summary

🤖 Generated by Copilot at 34d18d8

Refactored integration tests for server-prod module to use isomorphic-fetch and improved header access.

Details

🤖 Generated by Copilot at 34d18d8

  • Added isomorphic-fetch module to simplify HTTP testing in node and browser environments (link)
  • Replaced axios module with fetch function from isomorphic-fetch module for consistency and reliability in HTTP testing (link, link)
  • Updated header access syntax to use get method of Headers object returned by fetch function (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

⚠️ No Changeset found

Latest commit: 472b960

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zllkjc zllkjc enabled auto-merge (squash) August 11, 2023 10:22
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eae0e41) 57.28% compared to head (472b960) 57.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v1    #4424   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files         622      622           
  Lines       16011    16011           
  Branches     3409     3409           
=======================================
  Hits         9172     9172           
  Misses       6314     6314           
  Partials      525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zllkjc zllkjc merged commit 98cf845 into v1 Aug 11, 2023
6 checks passed
@zllkjc zllkjc deleted the fix/v1-test branch August 11, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants