Fetch: remove support for Response's trailer #20720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domfarolino,
jdm,
mnot,
youennf and
yutakahirano
jgraham
requested changes
Dec 12, 2019
fetch/api/basic/historical.any.js
Outdated
| }, "Headers object no longer has a getAll() method"); | ||
|
|
||
| test(() => { | ||
| const request = new Request("https://domfarolino.com"); |
There was a problem hiding this comment.
Using random domains makes me nervous, even if they shouldn't be contacted (it probably can't happen here but sometimes e.g. prefetching ends up causing forbidden requests). Can we just use the wpt domain instead?
jgraham
approved these changes
Dec 12, 2019
annevk
added a commit
to whatwg/fetch
that referenced
this pull request
Dec 12, 2019
As noted in #772 (comment) the current way it is exposed subsets what HTTP supports and therefore does not feel like a good starting point. Both for the internal and public API. Additionally, the public-facing API has not seen interest from implementers, at least for the past year and a half. Tests: web-platform-tests/wpt#20720. Closes #772. Follow-ups: #980 and #981.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/fetch#979.