[dom] Remove 'tentative' from AbortSignal.any() WPT test file name #39785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 1, 2023
s/abort-signal-any.tentative.any.js/abort-signal-any.any.js in preparation for landing the PR. Bug: 1323391 Change-Id: I981daef4eef9377dfc5b681ba86563ef2de53c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495130 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/main@{#1137974}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4495130
branch
from
57d027b
to
0f0075f
Compare
This was referenced May 1, 2023
annevk
pushed a commit
to whatwg/dom
that referenced
this pull request
May 17, 2023
- This implements an optimization that puts all children on non-dependent signals (i.e., those associated with a controller). This allows "intermediate" nodes (e.g., B in A follows B follows C) to be garbage collected if they are being kept alive to propagate aborts. - This removes the follow algorithm, so callsites will need to be updated. - The "create a composite abort signal" algorithm takes an interface so that TaskSignal.any() can easily hook into it, but create a TaskSignal. - Some algorithms that invoke "follow" create an AbortSignal in a particular realm. This enables doing that, but borrows some language from elsewhere in the spec w.r.t. doing the default thing. Neither of the other two static members specify a realm. Follow-up PRs: - whatwg/fetch#1646 - w3c/ServiceWorker#1678 - whatwg/streams#1277 This also sets the stage to make AbortSignal's "signal abort" fully internal. #1194 tracks the remainder. Tests: web-platform-tests/wpt#37434 and web-platform-tests/wpt#39785. Fixes #920.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/abort-signal-any.tentative.any.js/abort-signal-any.any.js in
preparation for landing the PR.
Bug: 1323391
Change-Id: I981daef4eef9377dfc5b681ba86563ef2de53c41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495130
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1137974}