Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async contract calls when a callback is passed #190

Closed
wants to merge 1 commit into from

Conversation

niran
Copy link
Contributor

@niran niran commented Apr 30, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e86552f on niran:async-contract-calls into * on ethereum:master*.

@niran
Copy link
Contributor Author

niran commented Apr 30, 2015

I put this together when I thought that synchronous contract calls were making my app slow, which was incorrect. This might not be worth pursuing in the near term, but at the very least, the documentation for Contract.call should mention that it should be so fast on localhost that you shouldn't really need an async version.

@niran
Copy link
Contributor Author

niran commented May 1, 2015

Never mind, the synchronous calls are actually making the app slow. What do I need to do to get something like this merged?

@debris
Copy link
Contributor

debris commented May 5, 2015

This looks good and I like the idea of having asynchronous calls, but unfortunately it interferes with toPayload method in SolidityFunction.prototype (see transactionObject in docs). We need a better way to solve passing arguments,callback and 'transactionObject' to solidity functions.

Suggestions are welcomed. 👍

@frozeman
Copy link
Contributor

frozeman commented May 5, 2015

Please direct your PR into develop no master. @debris can you take a look?

@debris
Copy link
Contributor

debris commented May 11, 2015

I'm closing, cause it's gonna be a part of #199. Thanks @niran !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants