Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support resourceQueryExclude option #165

Merged
merged 8 commits into from
Jun 23, 2022
Merged

support resourceQueryExclude option #165

merged 8 commits into from
Jun 23, 2022

Conversation

ben-lau
Copy link
Contributor

@ben-lau ben-lau commented Jun 13, 2022 •
edited
Loading

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

In #164 , the case of mpeg-ts file will lint as typescript file

Breaking Changes

No, resourceQueryExclude is optional

Additional Info

No

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 13, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

ricardogobbosouza
ricardogobbosouza requested changes Jun 19, 2022
View reviewed changes
commitlint.config.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
ricardogobbosouza
ricardogobbosouza requested changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts too

src/index.js Show resolved Hide resolved
@ricardogobbosouza
Copy link
Collaborator

ricardogobbosouza commented Jun 20, 2022 •
edited
Loading

Please, resolve conflicts too.
declarations moved to types

@ben-lau
Copy link
Contributor Author

ben-lau commented Jun 21, 2022

Please, resolve conflicts too. declarations moved to types

Sure, I will fetch the upstream

@codecov
Copy link

codecov bot commented Jun 22, 2022 •
edited
Loading

Codecov Report

Merging #165 (4ab48f8) into master (67efb34) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          273       276    +3     
  Branches        75        78    +3     
=========================================
+ Hits           273       276    +3
Impacted Files Coverage Δ
src/options.js 100.00% <ø> (ø)
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67efb34...4ab48f8. Read the comment docs.

@ricardogobbosouza ricardogobbosouza merged commit bd9cf94 into webpack-contrib:master Jun 23, 2022
ricardogobbosouza added a commit that referenced this pull request Jun 23, 2022
@ben-lau @ricardogobbosouza
feat: support resourceQueryExclude option (#165)
464120f 
* feat: resource query exclude option

* docs: update resource query exclude

* fix: fix quotes and parameters

* fix: fix the types

* chore: update lock file

* style: formatting

Co-authored-by: Ricardo Gobbo de Souza <ricardogobbosouza@yahoo.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardogobbosouza ricardogobbosouza ricardogobbosouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-lau @ricardogobbosouza