This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix for webpack 2 #312
Closed
fix for webpack 2 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix loaders
Update README.md
|
|
Current coverage is 85.84% (diff: 100%)@@ master #312 diff @@
==========================================
Files 4 4
Lines 332 332
Methods 68 68
Messages 0 0
Branches 71 71
==========================================
Hits 285 285
Misses 47 47
Partials 0 0
|
graingert
reviewed
Dec 21, 2016
| @@ -78,8 +78,8 @@ module.exports = { | |||
| ... | |||
| module: { | |||
| loaders: [ | |||
tleunen
reviewed
Dec 21, 2016
| @@ -78,8 +78,8 @@ module.exports = { | |||
| ... | |||
| module: { | |||
| loaders: [ | |||
| { test: /\.scss$/i, loader: extractCSS.extract(['css','sass']) }, | |||
| { test: /\.less$/i, loader: extractLESS.extract(['css','less']) }, | |||
| { test: /\.scss$/i, loader: extractCSS.extract(['css-loader','sass-loader']) }, | |||
There was a problem hiding this comment.
Related: #265
The problem is that, if you use use:, you get a crash.
|
Closing in favor of #349. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for use loaders with webpack2