Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow webpack 3 as peer, use webpack 3 as devDep #144

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Allow webpack 3 as peer, use webpack 3 as devDep #144

merged 1 commit into from
Jun 20, 2017

Conversation

snyamathi
Copy link
Contributor

@sokra @TheLarkInn

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Tests added? no
Docs updated? no
Fixed tickets None
License MIT

Since Webpack 3 has been released, this package should be updated to allow Webpack 3 as a peer dependency. Not really necessary, but I've also bumped the devDependency on Webpack to 3 as well.

The API between Webpack 2 and 3 seems to be unchanged, so I'm not aware of any differences that would need to be accounted for in this package, it should just be a loosening of the peerDependency that's required.

@jsf-clabot
Copy link

jsf-clabot commented Jun 20, 2017

CLA assistant check
All committers have signed the CLA.

@@ -21,7 +21,7 @@
"tasks"
],
"peerDependencies": {
"webpack": "^2.1.0-beta || ^2.2.0-rc || 2"
"webpack": "^2.1.0-beta || ^2.2.0-rc || 2 || 3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could also allow the release candidate versions here if I change that to ^3.0.0-rc but I'm not sure that's necessary now that 3.0.0 is out.

@codecov
Copy link

codecov bot commented Jun 20, 2017

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   67.64%   67.64%           
=======================================
  Files           8        8           
  Lines         204      204           
  Branches       52       52           
=======================================
  Hits          138      138           
  Misses         55       55           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d224f69...a02ab2e. Read the comment docs.

@danez
Copy link
Collaborator

danez commented Jun 20, 2017

Thanks.

@danez danez merged commit a6f42a2 into webpack-contrib:master Jun 20, 2017
@snyamathi snyamathi deleted the webpack3 branch June 20, 2017 21:13
@guidobouman
Copy link

guidobouman commented Jul 10, 2017

@danez Can a patch release be made based on this PR? Otherwise this results in both webpack 2 & 3 being installed in node_modules. Also, when using a peerDependency, shouldn't the devDependency be removed?

@danez
Copy link
Collaborator

danez commented Jul 10, 2017

the dev-dependency is for the tests. I will release a patch version.

@guidobouman
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants