Skip to content

Commit

Permalink
fix: add export default {} when CSS modules enabled and a file is e…
Browse files Browse the repository at this point in the history
…mpty for the `defaultExport` option
  • Loading branch information
houhongxu committed Aug 19, 2024
1 parent 3df97b6 commit 8f77e19
Show file tree
Hide file tree
Showing 6 changed files with 132 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,11 @@ function pitch(request) {
}

const result = (function makeResult() {
const defaultExport =
typeof options.defaultExport !== "undefined"
? options.defaultExport
: false;

if (locals) {
if (namedExport) {
const identifiers = Array.from(
Expand All @@ -281,11 +286,6 @@ function pitch(request) {
.map(([id, key]) => `${id} as ${JSON.stringify(key)}`)
.join(", ")} }`;

const defaultExport =
typeof options.defaultExport !== "undefined"
? options.defaultExport
: false;

return defaultExport
? `${localsString}\n${exportsString}\nexport default { ${identifiers
.map(([id, key]) => `${JSON.stringify(key)}: ${id}`)
Expand All @@ -297,7 +297,9 @@ function pitch(request) {
esModule ? "export default" : "module.exports = "
} ${JSON.stringify(locals)};`;
} else if (esModule) {
return "\nexport {};";
return defaultExport
? "\nexport {};export default {};"
: "\nexport {};";
}
return "";
})();
Expand Down
Empty file.
1 change: 1 addition & 0 deletions test/cases/es-named-and-default-export-1/expected/main.css
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

85 changes: 85 additions & 0 deletions test/cases/es-named-and-default-export-1/expected/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
/******/ (() => { // webpackBootstrap
/******/ "use strict";
/******/ var __webpack_modules__ = ([
/* 0 */,
/* 1 */
/***/ ((__unused_webpack_module, __webpack_exports__, __webpack_require__) => {

__webpack_require__.r(__webpack_exports__);
/* harmony export */ __webpack_require__.d(__webpack_exports__, {
/* harmony export */ "default": () => (__WEBPACK_DEFAULT_EXPORT__)
/* harmony export */ });
// extracted by mini-css-extract-plugin
/* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = ({});

/***/ })
/******/ ]);
/************************************************************************/
/******/ // The module cache
/******/ var __webpack_module_cache__ = {};
/******/
/******/ // The require function
/******/ function __webpack_require__(moduleId) {
/******/ // Check if module is in cache
/******/ var cachedModule = __webpack_module_cache__[moduleId];
/******/ if (cachedModule !== undefined) {
/******/ return cachedModule.exports;
/******/ }
/******/ // Create a new module (and put it into the cache)
/******/ var module = __webpack_module_cache__[moduleId] = {
/******/ // no module.id needed
/******/ // no module.loaded needed
/******/ exports: {}
/******/ };
/******/
/******/ // Execute the module function
/******/ __webpack_modules__[moduleId](module, module.exports, __webpack_require__);
/******/
/******/ // Return the exports of the module
/******/ return module.exports;
/******/ }
/******/
/************************************************************************/
/******/ /* webpack/runtime/define property getters */
/******/ (() => {
/******/ // define getter functions for harmony exports
/******/ __webpack_require__.d = (exports, definition) => {
/******/ for(var key in definition) {
/******/ if(__webpack_require__.o(definition, key) && !__webpack_require__.o(exports, key)) {
/******/ Object.defineProperty(exports, key, { enumerable: true, get: definition[key] });
/******/ }
/******/ }
/******/ };
/******/ })();
/******/
/******/ /* webpack/runtime/hasOwnProperty shorthand */
/******/ (() => {
/******/ __webpack_require__.o = (obj, prop) => (Object.prototype.hasOwnProperty.call(obj, prop))
/******/ })();
/******/
/******/ /* webpack/runtime/make namespace object */
/******/ (() => {
/******/ // define __esModule on exports
/******/ __webpack_require__.r = (exports) => {
/******/ if(typeof Symbol !== 'undefined' && Symbol.toStringTag) {
/******/ Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
/******/ }
/******/ Object.defineProperty(exports, '__esModule', { value: true });
/******/ };
/******/ })();
/******/
/************************************************************************/
var __webpack_exports__ = {};
// This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
(() => {
__webpack_require__.r(__webpack_exports__);
/* harmony import */ var _empty_css__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(1);


// eslint-disable-next-line no-console
console.log({ css: _empty_css__WEBPACK_IMPORTED_MODULE_0__["default"] });

})();

/******/ })()
;
4 changes: 4 additions & 0 deletions test/cases/es-named-and-default-export-1/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import css from "./empty.css";

// eslint-disable-next-line no-console
console.log({ css });
34 changes: 34 additions & 0 deletions test/cases/es-named-and-default-export-1/webpack.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import Self from "../../../src";

module.exports = {
entry: "./index.js",
module: {
rules: [
{
test: /\.css$/,
use: [
{
loader: Self.loader,
options: {
defaultExport: true,
},
},
{
loader: "css-loader",
options: {
esModule: true,
modules: {
namedExport: true,
},
},
},
],
},
],
},
plugins: [
new Self({
filename: "[name].css",
}),
],
};

0 comments on commit 8f77e19

Please sign in to comment.