Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node v18 to test workflow #67

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amareshsm
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add node v18 to test workflow

@amareshsm
Copy link
Contributor Author

please approve test workflows

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #67 (49c1e98) into master (861834c) will not change coverage.
The diff coverage is n/a.

❗ Current head 49c1e98 differs from pull request most recent head 42d1b11. Consider uploading reports for the commit 42d1b11 to get more accurate results

@@            Coverage Diff            @@
##            master       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           12        12           
  Branches         3         3           
=========================================
  Hits            12        12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861834c...42d1b11. Read the comment docs.

@amareshsm
Copy link
Contributor Author

Bump

@alexander-akait
Copy link
Member

We should fix tests

@amareshsm
Copy link
Contributor Author

Please approve workflows.

@alexander-akait
Copy link
Member

@amareshsm Can you rebase?

@amareshsm
Copy link
Contributor Author

@amareshsm Can you rebase?

done. Please approve workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants