Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with postcss@8 #479

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 15, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

compatibility with postcss@8

Breaking Changes

No

Additional Info

Plugin authors still need refactor code of own plugins

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files           5        5           
  Lines         238      238           
  Branches       75       75           
=======================================
  Hits          233      233           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1389c...636598f. Read the comment docs.

@@ -39,7 +39,7 @@
],
"peerDependencies": {
"webpack": "^4.0.0 || ^5.0.0",
"postcss": "^7.0.0"
"postcss": "^7.0.0 || ^8.0.1"
Copy link
Member Author

@alexander-akait alexander-akait Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postcss 8.0.0 has bug with reusing AST due invalid version on processor, fixed in 8.0.1

@alexander-akait alexander-akait merged commit 218b0f8 into master Sep 15, 2020
@alexander-akait alexander-akait deleted the fix-compatibility-with-postcss@8 branch September 15, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant