feat: better defaults (0CJS) with config generation #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenstensberg
changed the title
|
We can make it offline support + PWA here as well. Will implement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Better default settings for init generator
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
Sets better defaults if user is in production and if the user is using defaults.
Does this PR introduce a breaking change?
N/A
Other information
After this is done, we can use the default config generated from
webpack init --autoand use that as the default config for a webpack instance. After doing so, we can remove theisUsingDefaultslogic from the generator (or most of it) and put it as a non-config requirement in the core cli.TODO: