Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(package): migrate to schema-utils (dependencies) #1464

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Aug 24, 2018

Type

  • Refactor

Issues

  • None

SemVer

  • Patch (?)

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #1464 into master will increase coverage by 4.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1464      +/-   ##
=========================================
+ Coverage   78.94%   83.5%   +4.56%     
=========================================
  Files           5       4       -1     
  Lines         494     382     -112     
  Branches      161     113      -48     
=========================================
- Hits          390     319      -71     
+ Misses        104      63      -41
Impacted Files Coverage Δ
lib/Server.js 81.81% <100%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2220c4...42f01c7. Read the comment docs.

lib/options.json Outdated
"type": "string"
},
"https": {
"description": "Enable HTTPS for server.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove description, In the future, we can derive more friendly errors based on them

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@418493d). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1464   +/-   ##
========================================
  Coverage          ?   73.3%           
========================================
  Files             ?      10           
  Lines             ?     663           
  Branches          ?       0           
========================================
  Hits              ?     486           
  Misses            ?     177           
  Partials          ?       0
Impacted Files Coverage Δ
bin/webpack-dev-server.js 56.83% <0%> (ø)
lib/Server.js 80.16% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 418493d...daa2180. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title [WIP] refactor(package): migrate to schema-utils (dependencies) refactor(package): migrate to schema-utils (dependencies) Aug 29, 2018
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm just worried if we did not forget anything, maybe we'll add more tests

@michael-ciniawsky
Copy link
Member Author

michael-ciniawsky commented Aug 29, 2018

I can add some more, but tried to use at least one for ever different pattern for now. 'Some more' won't likely make it more reliable if we're not testing all of them then 😯

@alexander-akait
Copy link
Member

@michael-ciniawsky

we not testing all of them then
let's create issues/note for 4 version about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants