Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump up @types/ws package #4899

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

vatsalkgor
Copy link
Contributor

@vatsalkgor vatsalkgor commented Jun 9, 2023

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

DefinitelyTyped/DefinitelyTyped#65501 changed the types for Server. This is making the new builds for Angular application crash. Hence bumping the @types/ws package to reflect those changes in this package.

Breaking Changes

Additional Info

fixes #4894

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vatsalkgor / name: Vatsal Gor (56a5823)

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (3d61107) 91.85% compared to head (56a5823) 91.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4899      +/-   ##
==========================================
+ Coverage   91.85%   91.96%   +0.11%     
==========================================
  Files          16       16              
  Lines        1706     1706              
  Branches      649      649              
==========================================
+ Hits         1567     1569       +2     
+ Misses        128      126       -2     
  Partials       11       11              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait
Copy link
Member

Thank you for the PR, I will do release soon, but I really don't undestand why DefinitelyTyped allows developers make breaking changes, types should follow semver as a code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants